Graphics: shapes, gradients, and SF Symbols - #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth parity tier: graphics. Adds shape views, linear gradients, and SF Symbol images — the biggest visible gap after text/interaction.
What's new
Rectangle,Circle,Capsule,RoundedRectangle(cornerRadius:), each with.fill(Color); emitted as aShapenode the interpreter paints with the matching Compose shape.LinearGradient—LinearGradient(colors:startPoint:endPoint:)(and theGradientform) withUnitPoint; the interpreter picks horizontal/vertical/diagonal from the endpoints and fills available width.Image(systemName:)— a curated SF Symbol → Material icon map (~25 common symbols: star, heart, trash, gear, bell, cart, person…), tinted via.foregroundColorand sized via.frame. Unknown symbols and named assets keep the placeholder text so gaps stay visible.Verification
swift test— 3 new emission tests (shapes/fill/cornerRadius, gradient colors+endpoints, systemName), 44 total passingDeferred
Ellipse;.stroke; real asset images (no asset pipeline); radial/angular gradients. A shape with only a height (no width) still needs an explicit frame — the fill-the-parent layout behavior isn't modeled (gradients special-case fill-width).